Reduce ci load by running only on PR or push to master#331
Merged
Conversation
Contributor
Author
|
Current failure seems to be due to a GitHub outage, will revisit after fix is released |
ecoon
approved these changes
Dec 1, 2025
Collaborator
ecoon
left a comment
There was a problem hiding this comment.
approved pending question...
.github/workflows/ats-ci.yml
Outdated
| working-directory: Docker | ||
| run: | | ||
| echo "ATS_BRANCH=$GITHUB_REF_NAME" >> $GITHUB_ENV | ||
| echo "ATS_BRANCH=${{ github.event.pull_request.head.ref }}" >> $GITHUB_ENV |
Collaborator
There was a problem hiding this comment.
Does this work if it is not a PR, e.g. if push on master branch?
Contributor
Author
There was a problem hiding this comment.
Good catch, I'm not sure but I would guess not
I'll split this into two jobs that run w/ on different conditions
096bdb4 to
6f270c5
Compare
Contributor
Author
|
@ecoon updated the logic you had a question about |
saubhagya-gatech
pushed a commit
that referenced
this pull request
Feb 12, 2026
* only run ci on push to master and PRs to master * update ref GHA grabs on pull requests * also apply new ref to testing step * fix missing tag in manifest fix * fix ATS_BRANCH/ATS_BRANCH_TAG assignment based on github actions event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.